improve performance #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itoh-at-live2d-com
requested review from
itoh-at-live2d-com and
wada-at-live2d-com
|
@ppcuni We think that this performance improvement is very good. Sincelery, |
|
@ppcuni We have reviewed the performance improvement modifications you suggested. While this fix will certainly improve performance, we thought we could make it more useful to take advantage of the We've taken your improvements and made some changes to better handle them. If you approve with this, we would like to take our improvements and add them to CHANGELOG as you point out. Sincelery, |
itoh-at-live2d-com
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced overcalling Adress.ToPointer
↑After
↓Before