Removed build watch and tini from container run-time #891
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category:
Build related changes
Overview
Current production Dockerfile run-time command for the container is
yarn build-and-start
, that is a parallel run ofnode server
andvue-cli-service build --watch --mode production
. This parameter will make the build process keep watching the folder waiting to rebuild the app on any change. I guess this is related with 2 needs, developing or the app itself need to rebuild to show some changes.Presented Dockerfile just init the container with
yarn start
and removestini
, effectively using ~60 Mb of RAM (reduced from ~500Mb!), with no rebuilds. I restored my dashboard with ID and then created new items and everything seems to be working as it should, but no extensive testing has been done.Code Quality Checklist