Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed build watch and tini from container run-time #891

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

sur1v
Copy link
Contributor

@sur1v sur1v commented Sep 7, 2022

sur1v 🏗️ Architecture Quick sur1v /master → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: -1

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:
Build related changes

Overview
Current production Dockerfile run-time command for the container is yarn build-and-start, that is a parallel run of node server and vue-cli-service build --watch --mode production. This parameter will make the build process keep watching the folder waiting to rebuild the app on any change. I guess this is related with 2 needs, developing or the app itself need to rebuild to show some changes.

Presented Dockerfile just init the container with yarn start and removes tini, effectively using ~60 Mb of RAM (reduced from ~500Mb!), with no rebuilds. I restored my dashboard with ID and then created new items and everything seems to be working as it should, but no extensive testing has been done.

Code Quality Checklist

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors

@sur1v sur1v requested a review from Lissy93 as a code owner September 7, 2022 15:37
@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 60d0b03
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6318bace8f88e9000a464033
😎 Deploy Preview https://deploy-preview-891--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Sep 7, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 added the 🏗️ Architectural Changes [PR] Updates to application architecture, data flow or structure label Sep 10, 2022
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @sur1v
Thanks for this, have tested it, and seems to be working great

@Lissy93 Lissy93 merged commit 1046b44 into Lissy93:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ Architectural Changes [PR] Updates to application architecture, data flow or structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants