Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with built in auth, if user adds a capital letter to username they ca… #887

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

Cereal916
Copy link
Contributor

@Cereal916 Cereal916 commented Sep 6, 2022

Cereal916 🐛 Fix Quick Cereal916 /master → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0

…n see all items.

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:
Bugfix

Overview
I've found that if a user logs in with a capital letter in their name (their config username is all lowercase), then there's a loophole in the auth flow where the user doesn't get identified properly, and is able to view all items, even when they're not included in the showForUsers list.

Issue Number (if applicable) #00

Code Quality Checklist (Please complete)

  • [ X ] All changes are backwards compatible
  • [ X ] All lint checks and tests are passing
  • [ X ] There are no (new) build warnings or errors
  • [ X ] (If a new config option is added) Attribute is outlined in the schema and documented
  • [ X ] (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • [ X ] Bumps version, if new feature added

@Cereal916 Cereal916 requested a review from Lissy93 as a code owner September 6, 2022 03:53
@netlify
Copy link

netlify bot commented Sep 6, 2022

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 9c15314
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6316c44888ecba0009b7ce85
😎 Deploy Preview https://deploy-preview-887--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Sep 6, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@Lissy93 Lissy93 added the 🦋 Bug Fix [PR] Code includes bug fixes label Sep 10, 2022
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@Lissy93 Lissy93 merged commit e2fb5fc into Lissy93:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 Bug Fix [PR] Code includes bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants