-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Adds support for proxying CORS requests #392
Conversation
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: 746a377 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61cfab1e34857e0007ace80f 😎 Browse the preview: https://deploy-preview-392--dashy-dev.netlify.app/ |
This pull request is split into 4 parts for easier review. Changed files are located in these folders:
|
Before merging, I should probably also add this option to other widgets for self-hosted services. To prevent the same issue, and to keep things consistent. Not yet sure if I need to add a cloud function for Netlify too. Since users hosting the app on Netlify won't be able to integrate with locally-self-hosted apps, it might not be needed. I also still need to also add this option to the Configuring docs, bump version and update changelog. |
🎇 Happy New Year 🎇
Fixes #391 |
The fix for this issue has now been released in Dashy 2.0.0 ✨ If you haven't done so already, please update your instance to Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project. |
Co-authored-by: Dashboard Icons Bot <[email protected]>
Category: Improvement
Overview
Some users reporting facing CORS issues with the Pi-Hole widget. This option adds a new option that can be applied to a widget (
useProxy
) that will route the request through the Node proxy server, which contains the right headers.Issue Number #231, #391
New Vars
useProxy
- boolean, optionalScreenshot N/A
Code Quality Checklist (Please complete)