-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ARCH] Implement VueX State Management #271
Conversation
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: e1b812c 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/616313aa260b3a00088ce4c9 😎 Browse the preview: https://deploy-preview-271--dashy-dev.netlify.app |
Hi Lissy93! Thank you for contributing to Dashy! ✨ When updating dependencies, take a moment to verify that there are not security issues associated with any added or modified packages. If adding a new dependency, ensure that it is totally necessary, and check the packages size is not too large, as this will increase overall bundle size.
|
This pull request is split into 6 parts for easier review. Changed files are located in these folders:
|
/rebase |
This is quite a large PR, and includes significant architectural changes. It must be thoroughly tested before merging, to prevent unintentionally breaking anything. There aren't really any new user facing features here, but this PR lays the ground for the next big task - the new UI config editor. |
Size Change: +3.68 kB (0%) Total Size: 1.9 MB
ℹ️ View Unchanged
|
The fix for this issue has now been released in Dashy 1.9.0 ✨ If you haven't done so already, please update your instance to Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project. |
%20after%20argument%20list/red)
Category: Refactoring
Overview
Vuex is a state management pattern + library for Vue apps, like Dashy. It will serve as a centralized data store, and has rules to ensure that the state can only be mutated in a predictable fashion. To learn more, see the VueX Docs.
Implementing this will lead to a more ogranised code base long term, but will also make building out the new UI editor significantly easier to do in a clean and reliable way.
Issue Number N/A
New Vars N/A
Screenshot N/A
Code Quality Checklist (Please complete)