Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improved Loading #238

Merged
merged 8 commits into from
Sep 19, 2021
Merged

[FEATURE] Improved Loading #238

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0927ea8
:zap: Show loader when route changes
Lissy93 Sep 19, 2021
6e0cda8
:children_crossing: Adds user-facing warning logging
Lissy93 Sep 19, 2021
cdab798
:zap: Replace error with warning for failed user actions
Lissy93 Sep 19, 2021
b00c9ad
:sparkles: Show splash screen before app loaded
Lissy93 Sep 19, 2021
b532e16
:dizzy: Hide loader, if still visible
Lissy93 Sep 19, 2021
d6a2c4d
:fire: Splash screen now off by default
Lissy93 Sep 19, 2021
b3d0519
:bookmark: Bumps to V 1.8.3 and updates changelog
Lissy93 Sep 19, 2021
3a301af
:wheelchair: Adds lang attr, for accessibility
Lissy93 Sep 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
💫 Hide loader, if still visible
  • Loading branch information
@Lissy93
Lissy93 committed Sep 19, 2021
commit b532e168fe2da0fb6b96f8d2601ed3e9e8641ec5
8 changes: 6 additions & 2 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ export default {
},
/* Determine if splash screen should be shown */
shouldShowSplash() {
return (this.visibleComponents || defaultVisibleComponents).splashScreen
|| !localStorage[localStorageKeys.HIDE_WELCOME_BANNER];
return (this.visibleComponents || defaultVisibleComponents).splashScreen;
},
},
methods: {
Expand Down Expand Up @@ -107,6 +106,10 @@ export default {
this.$i18n.locale = language;
document.getElementsByTagName('html')[0].setAttribute('lang', language);
},
hideLoader() {
const loader = document.getElementById('loader');
if (loader) loader.style.display = 'none';
},
},
/* When component mounted, hide splash and initiate the injection of custom styles */
mounted() {
Expand All @@ -115,6 +118,7 @@ export default {
if (this.appConfig.customCss) {
const cleanedCss = this.appConfig.customCss.replace(/<\/?[^>]+(>|$)/g, '');
this.injectCustomStyles(cleanedCss);
this.hideLoader();
}
welcomeMsg();
},
Expand Down