Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🇷🇴 Romanian translation #1521

Merged
merged 4 commits into from
Mar 27, 2024
Merged

🇷🇴 Romanian translation #1521

merged 4 commits into from
Mar 27, 2024

Conversation

z3r0l1nk
Copy link
Contributor

@z3r0l1nk z3r0l1nk commented Mar 25, 2024

z3r0l1nk Medium z3r0l1nk /master → Lissy93/dashy Commits: 4 | Files Changed: 2 | Additions: 455 Label Unchecked Tasks Powered by Pull Request Badge

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

Translation

Overview

Created new "ro.json"

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@z3r0l1nk z3r0l1nk requested a review from Lissy93 as a code owner March 25, 2024 09:49
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 8656606
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6603d3e838e8e20008da6fc3
😎 Deploy Preview https://deploy-preview-1521--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @z3r0l1nk
Just one small thing left, you need to import this into languages.js - here's how

If you're struggling, I'd be happy to do it

@z3r0l1nk
Copy link
Contributor Author

Looks great, thanks @z3r0l1nk Just one small thing left, you need to import this into languages.js - here's how

If you're struggling, I'd be happy to do it

Hello,
Sorry I missed the languages.js file.
I made the necessary adjustments to it now :)

Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Lissy93 Lissy93 merged commit 5d26f8a into Lissy93:master Mar 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants