Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cutToHeight does not work #461

Closed
4 tasks done
MihataBG opened this issue Jan 31, 2022 · 5 comments
Closed
4 tasks done

cutToHeight does not work #461

MihataBG opened this issue Jan 31, 2022 · 5 comments
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@MihataBG
Copy link

MihataBG commented Jan 31, 2022

Environment

Self-Hosted (Docker)

Version

2.0.0

Describe the problem

When we set cutToHeight: true, it does not work also go to error in configuration editor:
cutToHeight

Additional info

Theme is "Colorful"

Please tick the boxes

@MihataBG MihataBG added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Jan 31, 2022
@MihataBG
Copy link
Author

To resolve the error messages cutToHeight has to be added to ConfigSchema.json?

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 31, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Jan 31, 2022

Your right, looks like I forgot to add this to ConfigSchema.json.

I'll get that fixed this evening

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 31, 2022
@MihataBG
Copy link
Author

Its so good, but this does not resolve the problem with "colorful" theme.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 31, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Jan 31, 2022

Ah yeah, that seems to be caused by this line within the colourful theme block.

.collapsable.is-open {
height: -webkit-fill-available;
}

I'll add that to the fix too :)

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jan 31, 2022
Lissy93 added a commit that referenced this issue Jan 31, 2022
@Lissy93
Copy link
Owner

Lissy93 commented Feb 9, 2022

Forgot to say, but this was fixed in #462

@Lissy93 Lissy93 closed this as completed Feb 9, 2022
asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
None yet
Development

No branches or pull requests

3 participants