Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE_REQUEST] Allow using different faviconApi for each items #196

Closed
zephyros-dev opened this issue Sep 2, 2021 · 2 comments
Closed
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 👩‍💻 Good First Issue [ISSUE] Great task for newcomers to work on 💤 Low Priority [ISSUE] Nice to have, but not currently in scope

Comments

@zephyros-dev
Copy link

zephyros-dev commented Sep 2, 2021

Is your feature request related to a problem? If so, please describe.

Some of my internet-facing site have basic-auth, so the faviconkit API cannot get the icon for them. For example:

appConfig:
  faviconApi: faviconkit
  statusCheck: true
  theme: Material
sections:
  - name: Media management
    items:
# This service has basic-auth
      - icon: favicon
        statusCheckAllowInsecure: true
        statusCheckUrl: http://radarr:7878
        title: Radarr
        url: https://radarr.{{ server_domain }}
# This service doesn't have basic-auth
      - icon: favicon
        title: Nextcloud
        url: https://nextcloud.{{ server_domain }}

Using faviconkit will not return a favicon for the site with basic-auth.
image
If I change the faviconApi to local, I'm not sure how it works, but the icon appears normally. However, other services without basic-auth doesn't have icons anymore.
image

Describe the solution you'd like

Allow using different faviconApi for each items entry. Something like this:

appConfig:
  statusCheck: true
  theme: Material
sections:
  - name: Media management
    items:
# This service has basic-auth
      - icon: favicon
        faviconApi: local
        statusCheckAllowInsecure: true
        statusCheckUrl: http://radarr:7878
        title: Radarr
        url: https://radarr.{{ server_domain }}
# This service doesn't have basic-auth
      - icon: favicon
        faviconApi: faviconkit
        title: Nextcloud
        url: https://nextcloud.{{ server_domain }}

Priority

Low (Nice-to-have)

Is this something you would be keen to implement

No response

@zephyros-dev zephyros-dev added the 🦄 Feature Request [ISSUE] Suggestion for new feature, update or change label Sep 2, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Sep 2, 2021

Thanks for the suggestion, I can certainly implement this, should be a quick task. Will do it this weekend :)

@Lissy93 Lissy93 added 👩‍💻 Good First Issue [ISSUE] Great task for newcomers to work on 💤 Low Priority [ISSUE] Nice to have, but not currently in scope labels Sep 2, 2021
@Lissy93 Lissy93 closed this as completed in 09bc8a3 Sep 4, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Sep 4, 2021

Hey @phongngthanh - This is implemented in b756e65 of #201 released in V 1.7.1.

You can now use a different favicon API for certain items, just set icon: favicon-[api], e.g. favicon-clearbit

Hope that helps :)

P.s if you're enjoying Dashy, pls consider staring the repo

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 Feature Request [ISSUE] Suggestion for new feature, update or change 👩‍💻 Good First Issue [ISSUE] Great task for newcomers to work on 💤 Low Priority [ISSUE] Nice to have, but not currently in scope
Projects
None yet
Development

No branches or pull requests

2 participants