Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Scrolling in mobile constantly brings up edit menu on icons/items. #1261

Closed
5 tasks done
redge76 opened this issue Jul 14, 2023 · 11 comments
Closed
5 tasks done
Assignees
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@redge76
Copy link

redge76 commented Jul 14, 2023

Environment

Self-Hosted (Docker)

System

Docker running on an Ubuntu system

Version

latest

Describe the problem

When scrolling up and down in mobile view you have to put your finger on the items or icons to scroll. When you do so it bring up the context menu for that item. This is extremely annoying and makes the dashboard painful to use because then I have to click to dismiss the context menu before I click an item on my dashboard.
This is duplicate of #1135 (already closed)

Additional info

This issue can be easly reproduced using the dev tools in chrome.

  1. Open a dashy instance
  2. Start dev tools
  3. Switch to a mobile browser simulation with the device toolbar (ctrl + shift + M)

Please tick the boxes

@redge76 redge76 added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Jul 14, 2023
@liss-bot
Copy link
Collaborator

If you're enjoying Dashy, consider dropping us a ⭐
🤖 I'm a bot, and this message was automated

@redge76
Copy link
Author

redge76 commented Jul 18, 2023

v1.9.2 running on https://live.dashy.to/ of https://demo.dashy.to/ is not impacted by this bug.
v2.1.1 running on https://dev.dashy.to/ is impacted.

I guess it is related to the longpress detection in file LongPress.js. It seems that this code does not take in account the possibility of a "touch/drag" gesture. It only check le lenght the screen is touched without verifying if the touch location has moved.

Sorry but I have no skill with nodejs and I can't correct this myself.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending labels Jul 18, 2023
@redge76
Copy link
Author

redge76 commented Aug 7, 2023

The best workaround I found is to disable the context menu altogether.
edit mode -> edit app config -> Disable Context Menus
These context menu are not mandatory and at least dashy is usable on a mobile.

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Aug 7, 2023
@shall0pass
Copy link

I have this same issue. It would be nice if we could only disable the context menus on small screens that are more likely to have touch interfaces.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Aug 12, 2023
@liss-bot

This comment was marked as duplicate.

@liss-bot liss-bot added the ⚰️ Stale [ISSUE] [PR] No activity for over 1 month label Nov 10, 2023
@github-project-automation github-project-automation bot moved this to Todo in Dashy V3 Nov 10, 2023
@redge76

This comment was marked as duplicate.

@liss-bot liss-bot added 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending and removed ⚰️ Stale [ISSUE] [PR] No activity for over 1 month labels Nov 10, 2023
@mooglestiltzkin
Copy link

mooglestiltzkin commented Nov 14, 2023

i solved the context issue by disabling it. like others pointed out, why not disable for small screens as a default? surely i am not the only one having scrolling issues cauzing pop ups. Sure the simple solution is to turn it off. but at least mention that in the setup guide for mobile users.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Nov 16, 2023
@mainTAP
Copy link

mainTAP commented Nov 25, 2023

Is it possible to disable the context menus for the mobile device only ? I've tried to "save locally" but when I refresh the window it re-enables the context menus again. Thank you

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Nov 25, 2023
@OxYancy

This comment was marked as duplicate.

@CrazyWolf13

This comment was marked as off-topic.

@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Feb 23, 2024
@ddenev
Copy link
Contributor

ddenev commented Jun 22, 2024

@Lissy93, any chance you review and eventually merge the fix I provided?
The issue is relly annoying on a mobile device 🙂
Thank you in advance!

@liss-bot liss-bot added the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 22, 2024
Lissy93 added a commit that referenced this issue Jun 30, 2024
[Fix] Scolling on mobile brings up menu #1261
@github-project-automation github-project-automation bot moved this from Awaiting Triage to Done in Dashy V3 Jun 30, 2024
@liss-bot liss-bot removed the 👤 Awaiting Maintainer Response [ISSUE] Response from repo author is pending label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
Status: Done
Development

No branches or pull requests

9 participants