Added input validation to OpenFile and CreateFile methods #322

[TheBaronOfDubstep]

Recreated the pull request to ensure I have only verified commits and all code style checks will succeed

[TheBaronOfDubstep]

@LiorBanai As I do not know whether or not this nuget is cross platform, I will not introduce a binding to kernel32.dll. This code is ready for merge

[LiorBanai]

Thanks! . I'll review it. And yes it is cross platform but we can check the running platform and bind only on windows.

[TheBaronOfDubstep]

Thanks! . I'll review it. And yes it is cross platform but we can check the running platform and bind only on windows.

Sounds great. I'll just read up on the compiler macros for that, and I'll send you another that will compile. I have no idea why this one won't.

[TheBaronOfDubstep]

@LiorBanai new version is up and should compile better :)

[TheBaronOfDubstep]

@LiorBanai Again, sorry for the commit spam. Tried to stay within guidelines of the static code analysis, but it promotes outdated code standards (for c# 4) and advocates against current best practices (for c# 7)

[LiorBanai]

@TheBaronOfDubstep Don't worry about the static code analysis.. it is indeed need revising...
I plan to add editorconfig not far away.

[LiorBanai]

AS long ad the code compiled and unit tests passes that is what important.
any chance you can add some specific tests?

[TheBaronOfDubstep]

I can add tests for the input sanitation, but I am not sure if the tests will run if I include the kernel32.dll call in them

[TheBaronOfDubstep]

@LiorBanai Tests are added for the added functionality of this PR.

[LiorBanai]

@TheBaronOfDubstep I'll review it this weekend.
Thanks! :)

[LiorBanai]

@TheBaronOfDubstep Thanks