Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bz2 compress support #179

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Add bz2 compress support #179

merged 1 commit into from
Oct 22, 2021

Conversation

LinuxSuRen
Copy link
Owner

@LinuxSuRen LinuxSuRen commented Oct 21, 2021

fix #176

hi @seanly, would you mind helping to review this PR?

@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #179 (888c2ea) into master (992a572) will decrease coverage by 0.36%.
The diff coverage is 14.70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   16.08%   15.71%   -0.37%     
==========================================
  Files          28       29       +1     
  Lines        1517     1546      +29     
==========================================
- Hits          244      243       -1     
- Misses       1253     1283      +30     
  Partials       20       20              
Flag Coverage Δ
unittests 15.71% <14.70%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/install.go 0.00% <ø> (ø)
pkg/compress/bzip2.go 0.00% <0.00%> (ø)
pkg/installer/check.go 18.30% <33.33%> (-1.29%) ⬇️
pkg/compress/types.go 42.85% <66.66%> (+3.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992a572...888c2ea. Read the comment docs.

@seanly
Copy link
Contributor

seanly commented Oct 22, 2021

test steps:

  1. create config/restic/restic.yml in ~/.config/hd-home directory
filename: "restic_{{.VersionNum}}_{{.OS}}_{{.Arch}}.bz2"
binary: restic
  1. install restic
bin/hd install restic/restic

result:
image

@LinuxSuRen LinuxSuRen merged commit 46bca63 into master Oct 22, 2021
@LinuxSuRen LinuxSuRen deleted the bz2-support branch October 22, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to support bz2 package format
2 participants