Fix the context check (#107)

cmd/get.go

@@ -17,7 +17,7 @@ import (
 // newGetCmd return the get command
 func newGetCmd(ctx context.Context) (cmd *cobra.Command) {
 	opt := &downloadOption{
-		RoundTripper: *getRoundTripper(ctx),
+		RoundTripper: getRoundTripper(ctx),
 	}
 	cmd = &cobra.Command{
 		Use:     "get",

cmd/install.go

@@ -12,7 +12,7 @@ import (
 func newInstallCmd(ctx context.Context) (cmd *cobra.Command) {
 	opt := &installOption{
 		downloadOption: downloadOption{
-			RoundTripper: *getRoundTripper(ctx),
+			RoundTripper: getRoundTripper(ctx),
 		},
 	}
 	cmd = &cobra.Command{

cmd/util.go

@@ -17,31 +17,19 @@ func getOrDefault(key, def string, data map[string]string) (result string) {
 	return
 }
 
-func getReplacement(key string, data map[string]string) (result string) {
-	return getOrDefault(key, key, data)
-}
+func getRoundTripper(ctx context.Context) (tripper http.RoundTripper) {
+	if ctx == nil {
+		return
+	}
 
-func getRoundTripper(ctx context.Context) (tripper *http.RoundTripper) {
 	roundTripper := ctx.Value("roundTripper")
-
-	var ok bool
-	if tripper, ok = roundTripper.(*http.RoundTripper); ok {
-		tripper = nil
+	switch v := roundTripper.(type) {
+	case *http.Transport:
+		tripper = v
 	}
 	return
 }
 
-func pathExists(path string) (bool, error) {
-	_, err := os.Stat(path)
-	if err == nil {
-		return true, nil
-	}
-	if os.IsNotExist(err) {
-		return false, nil
-	}
-	return false, err
-}
-
 func execCommandInDir(name, dir string, arg ...string) (err error) {
 	command := exec.Command(name, arg...)
 	if dir != "" {
@@ -75,10 +63,6 @@ func execCommandInDir(name, dir string, arg ...string) (err error) {
 	return
 }
 
-func execCommand(name string, arg ...string) (err error) {
-	return execCommandInDir(name, "", arg...)
-}
-
 func copyAndCapture(w io.Writer, r io.Reader) ([]byte, error) {
 	var out []byte
 	buf := make([]byte, 1024, 1024)

cmd/util_test.go

@@ -0,0 +1,79 @@
+package cmd
+
+import (
+	"context"
+	"net/http"
+	"reflect"
+	"testing"
+)
+
+func Test_getRoundTripper(t *testing.T) {
+	type args struct {
+		ctx context.Context
+	}
+	tests := []struct {
+		name        string
+		args        args
+		wantTripper http.RoundTripper
+	}{{
+		name:        "context is nil",
+		wantTripper: nil,
+	}, {
+		name: "invalid type of RounderTripper in the context",
+		args: args{
+			ctx: context.WithValue(context.TODO(), "roundTripper", "invalid"),
+		},
+		wantTripper: nil,
+	}, {
+		name: "valid type of RounderTripper in the context",
+		args: args{
+			ctx: context.WithValue(context.TODO(), "roundTripper", &http.Transport{}),
+		},
+		wantTripper: &http.Transport{},
+	}}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if gotTripper := getRoundTripper(tt.args.ctx); !reflect.DeepEqual(gotTripper, tt.wantTripper) {
+				t.Errorf("getRoundTripper() = %v, want %v", gotTripper, tt.wantTripper)
+			}
+		})
+	}
+}
+
+func Test_getOrDefault(t *testing.T) {
+	type args struct {
+		key  string
+		def  string
+		data map[string]string
+	}
+	tests := []struct {
+		name       string
+		args       args
+		wantResult string
+	}{{
+		name: "no key exist",
+		args: args{
+			key: "key",
+			def: "def",
+			data: map[string]string{},
+		},
+		wantResult: "def",
+	}, {
+		name: "key exist",
+		args: args{
+			key: "key",
+			def: "def",
+			data: map[string]string{
+				"key": "key",
+			},
+		},
+		wantResult: "key",
+	}}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if gotResult := getOrDefault(tt.args.key, tt.args.def, tt.args.data); gotResult != tt.wantResult {
+				t.Errorf("getOrDefault() = %v, want %v", gotResult, tt.wantResult)
+			}
+		})
+	}
+}