quantiles calculations #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommonClimate
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Thanks for this! I like that it returns another EnsembleSeries, and I like that there is also the option to export to dataframe or NumPy array. Please make sure to create an issue in pyleotutorials to add that to the Ensembles tutorial.
re: quantiles, I have 2 requests:
- As I mentioned somewhere on Slack, "mode" should be "axis", for consistency with NumPy, but also because mode is a statistically loaded term. Let's stay away from it.
- the docstring incorrectly mentions "If mode is 'paleo'". I believe it should say "If axis is set to 'value'"...
|
Changes made |
CommonClimate
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to calculate the quantiles on time instead of values. Also added capability to export an ensemble series to a pandas dataframe or numpy array. Useful to get the quantiles in a more analysis-ready format.
Added docstrings and tests for all functions (note: there was no test for quantiles)