Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
resample
results look a bit odd, in that the labels are always from the year-end:This is because we're using multiples of
'Y'
as the resample rule, which means "year end" - https://pandas.pydata.org/docs/dev/user_guide/timeseries.html#dateoffset-objectsMy bad here, I should've used
'AS'
the first time. I think this make it align more with user expectations anyway.The above example would look like this:
There is still some rounding error in the
years CE
representation, due to using an approximation for the number of seconds in the year:Pyleoclim_util/pyleoclim/utils/tsbase.py
Lines 24 to 25 in 0da854c
I've also added a test for
resample.interpolate