Add extra index to pip install #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am happy to approve, with the caveat that I cannot easily test this. Shall I assume you have, and the container builds? |
|
The container builds but the tests are failing. |
|
I am aware ; I need to fix a zillion bugs locally before they have a chance of passing via CI. This is going to take a little while. I'll update on progress on Slack |
|
I did test this locally, but I was waiting for tests to pass to confirm. When I took a closer look, I realized that the extra index was working, but it wasn't picking up pandas from that index. I made some changes here #307 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the extra index to the nightly build in the environment file. We've been using this syntax via the CLI, but since it wasn't in the environment.yml, the CI wasn't including it.
Resolves LinkedEarth/paleoPandas#23