Allow to use different prime field element implementations #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, even though the `F: PrimeField` was generic in `Poseidon` struct and traits it implements, Poseidon parameters were still defined as `Fq`. To allow usage of different prime field element types (i.e. `Fr`), the parameters have to be generic as well. However, since the `new()` method is not a part of `PrimeField` trait, functions returining parameters can't be generic, so they are handled with a macro instead. Signed-off-by: Michal Rostecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, even though the
F: PrimeFieldwas generic inPoseidonstruct and traits it implements, Poseidon parameters were still defined asFq.To allow usage of different prime field element types (i.e.
Fr), the parameters have to be generic as well.However, since the
new()method is not a part ofPrimeFieldtrait, functions returining parameters can't be generic, so they are handled with a macro instead.Signed-off-by: Michal Rostecki [email protected]