Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added type annotations to pl_bolts/optimizers #608

Closed
wants to merge 2 commits into from
Closed

added type annotations to pl_bolts/optimizers #608

wants to merge 2 commits into from

Conversation

johnpeterson123
Copy link

@johnpeterson123 johnpeterson123 commented Mar 26, 2021

What does this PR do?

Part of #434

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

Hello @johnpeterson123! Thanks for opening this PR.

Line 92:15: W503 line break before binary operator
Line 102:70: W504 line break after binary operator
Line 105:15: W504 line break after binary operator
Line 108:74: W504 line break after binary operator
Line 121:56: W504 line break after binary operator
Line 122:50: W504 line break after binary operator
Line 130:70: W504 line break after binary operator

Do see the Hitchhiker's guide to code style

@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #608 (4410327) into master (9044ed1) will increase coverage by 0.06%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   25.20%   25.26%   +0.06%     
==========================================
  Files         118      118              
  Lines        7119     7125       +6     
==========================================
+ Hits         1794     1800       +6     
  Misses       5325     5325              
Flag Coverage Δ
cpu 25.26% <86.36%> (+0.06%) ⬆️
pytest 25.26% <86.36%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pl_bolts/optimizers/lars_scheduling.py 35.84% <76.92%> (+8.18%) ⬆️
pl_bolts/optimizers/lr_scheduler.py 93.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9044ed1...4410327. Read the comment docs.

@Borda Borda added the enhancement New feature or request label Mar 30, 2021
pl_bolts/optimizers/lr_scheduler.py Outdated Show resolved Hide resolved
pl_bolts/optimizers/lr_scheduler.py Outdated Show resolved Hide resolved
@akihironitta akihironitta mentioned this pull request Mar 30, 2021
17 tasks
@akihironitta akihironitta removed the enhancement New feature or request label Apr 19, 2021
@mergify mergify bot added the has conflicts label May 9, 2021
@Borda
Copy link
Member

Borda commented Jun 15, 2021

@johnpeterson123 mind check review comments and conflicts? 🐰

@Borda
Copy link
Member

Borda commented Jul 28, 2021

@johnpeterson123 how is it going here? mind resolve conflicts? 🐰

@mergify mergify bot removed the has conflicts label Sep 6, 2021
@Borda
Copy link
Member

Borda commented Sep 6, 2021

@SeanNaren mind check it if we can quick let it land, otherwise we may close it as @johnpeterson123 is not responding

@SeanNaren
Copy link
Contributor

@Borda not sure we should add so many ignores as @akihironitta mentions in #434 (comment)

Is there a way to do this typing without all these ignores?

@Borda Borda marked this pull request as draft September 7, 2021 10:05
@Borda Borda added waiting on author won't fix This will not be worked on labels Sep 7, 2021
@stale stale bot removed the won't fix This will not be worked on label Sep 7, 2021
@akihironitta
Copy link
Contributor

Feel free to reopen this PR if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants