-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added type annotations to pl_bolts/optimizers #608
added type annotations to pl_bolts/optimizers #608
Conversation
Hello @johnpeterson123! Thanks for opening this PR.
Do see the Hitchhiker's guide to code style |
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
+ Coverage 25.20% 25.26% +0.06%
==========================================
Files 118 118
Lines 7119 7125 +6
==========================================
+ Hits 1794 1800 +6
Misses 5325 5325
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@johnpeterson123 mind check review comments and conflicts? 🐰 |
@johnpeterson123 how is it going here? mind resolve conflicts? 🐰 |
for more information, see https://pre-commit.ci
@SeanNaren mind check it if we can quick let it land, otherwise we may close it as @johnpeterson123 is not responding |
@Borda not sure we should add so many ignores as @akihironitta mentions in #434 (comment) Is there a way to do this typing without all these ignores? |
Feel free to reopen this PR if needed. |
What does this PR do?
Part of #434
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃