-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds CNN Trainer #286
Adds CNN Trainer #286
Conversation
Hello @oke-aditya! Thanks for updating this PR.
Comment last updated at 2020-10-18 19:32:33 UTC |
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
- Coverage 83.87% 82.44% -1.43%
==========================================
Files 91 94 +3
Lines 4861 4984 +123
==========================================
+ Hits 4077 4109 +32
- Misses 784 875 +91
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@oke-aditya how is it going here, still wip? |
Hey @Borda, Actually, the code is complete. I need to add tests as well though. @justusschock said this might need more discussion hence I kept as WIP. We can discuss on this PR, I guess it is good feature addition though. This can be used to solve #340 too. |
let's close this one for now... :] |
Before submitting
What does this PR do?
Fixes #203
Adds a generic CNN Trainer that works for torchvision models.
PR review
I need a bit help to write tests and with the
run_cli()
method. I'm not sure if they are right.I have tested this code and it works fine in my repo. It is here
Did you have fun?
Make sure you had fun coding 🙃