removing bias from linear model regularisation

Lightning-Universe · Jun 23, 2021 · c83c763 · c83c763
1 parent 354534a
commit c83c763
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pl_bolts/models/regression/linear_regression.py b/pl_bolts/models/regression/linear_regression.py
@@ -58,12 +58,12 @@ def training_step(self, batch: Tuple[Tensor, Tensor], batch_idx: int) -> Dict[st
 
         # L1 regularizer
         if self.hparams.l1_strength > 0:
-            l1_reg = sum(param.abs().sum() for param in self.parameters())
+            l1_reg = self.linear.weight.abs().sum()
             loss += self.hparams.l1_strength * l1_reg
 
         # L2 regularizer
         if self.hparams.l2_strength > 0:
-            l2_reg = sum(param.pow(2).sum() for param in self.parameters())
+            l2_reg = self.linear.weight.pow(2).sum()
             loss += self.hparams.l2_strength * l2_reg
 
         loss /= x.size(0)

diff --git a/pl_bolts/models/regression/logistic_regression.py b/pl_bolts/models/regression/logistic_regression.py
@@ -61,12 +61,12 @@ def training_step(self, batch: Tuple[Tensor, Tensor], batch_idx: int) -> Dict[st
 
         # L1 regularizer
         if self.hparams.l1_strength > 0:
-            l1_reg = sum(param.abs().sum() for param in self.parameters())
+            l1_reg = self.linear.weight.abs().sum()
             loss += self.hparams.l1_strength * l1_reg
 
         # L2 regularizer
         if self.hparams.l2_strength > 0:
-            l2_reg = sum(param.pow(2).sum() for param in self.parameters())
+            l2_reg = self.linear.weight.pow(2).sum()
             loss += self.hparams.l2_strength * l2_reg
 
         loss /= x.size(0)