Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune deprecated #92

Merged
merged 3 commits into from
Mar 17, 2021
Merged

Prune deprecated #92

merged 3 commits into from
Mar 17, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 16, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

the removed argument that has not been used anyway...

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Mar 16, 2021
@Borda Borda enabled auto-merge (squash) March 16, 2021 12:34
@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #92 (6fc8a81) into master (02f0450) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #92     +/-   ##
=========================================
  Coverage   97.15%   97.15%             
=========================================
  Files         122       61     -61     
  Lines        4006     2003   -2003     
=========================================
- Hits         3892     1946   -1946     
+ Misses        114       57     -57     
Flag Coverage Δ
Linux 78.77% <ø> (ø)
Windows 78.77% <ø> (ø)
cpu 97.15% <ø> (ø)
gpu ?
macOS 97.15% <ø> (ø)
pytest 97.15% <ø> (ø)
python3.6 97.14% <ø> (ø)
python3.8 97.15% <ø> (ø)
python3.9 97.15% <ø> (ø)
torch1.3.1 95.44% <ø> (ø)
torch1.4.0 95.60% <ø> (ø)
torch1.8.0 97.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/classification/checks.py 100.00% <ø> (ø)
torchmetrics/classification/precision_recall.py 100.00% <ø> (ø)
torchmetrics/classification/stat_scores.py 100.00% <ø> (ø)
...rics/functional/classification/precision_recall.py 100.00% <ø> (ø)
...chmetrics/functional/classification/stat_scores.py 100.00% <ø> (ø)
.../s/torchmetrics/classification/hamming_distance.py
...2/s/torchmetrics/functional/classification/dice.py
...rics/functional/classification/confusion_matrix.py
__w/2/s/torchmetrics/utilities/data.py
__w/2/s/torchmetrics/classification/f_beta.py
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02f0450...6fc8a81. Read the comment docs.

Comment on lines +55 to +56
.. note:: What is considered a sample in the multi-dimensional multi-class case
depends on the value of ``mdmc_average``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. note:: What is considered a sample in the multi-dimensional multi-class case
depends on the value of ``mdmc_average``.
.. note:: A sample considered in the multi-dimensional multi-class case
depends on the value of ``mdmc_average``.

Similar suggestion to other changes.

@Borda Borda merged commit 036d1c6 into master Mar 17, 2021
@Borda Borda deleted the prune/deprecated branch March 17, 2021 10:56
@Borda Borda added this to the 0.3 milestone Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants