Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOI: rename Term -> Time #765

Merged
merged 4 commits into from
Jan 17, 2022
Merged

STOI: rename Term -> Time #765

merged 4 commits into from
Jan 17, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 17, 2022 •
edited
Loading

What does this PR do?

Fixes #753 (comment)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added refactoring refactoring and code health API / design labels Jan 17, 2022
@Borda Borda added this to the v0.7 milestone Jan 17, 2022
@Borda Borda marked this pull request as ready for review January 17, 2022 11:43
@Borda Borda changed the title rename STOI STOI: rename Term -> Time Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022 •
edited
Loading

Codecov Report

Merging #765 (850e8d6) into master (0d18bda) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #765   +/-   ##
=====================================
  Coverage      95%    95%           
=====================================
  Files         171    171           
  Lines        6913   6913           
=====================================
+ Hits         6538   6555   +17     
+ Misses        375    358   -17

@Borda Borda enabled auto-merge (squash) January 17, 2022 11:46
stancld
stancld approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@stancld stancld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch!

just two minimal comments for deprecated function/module

torchmetrics/audio/stoi.py Outdated Show resolved Hide resolved
torchmetrics/functional/audio/stoi.py Outdated Show resolved Hide resolved
Borda and others added 2 commits January 17, 2022 12:55
@Borda Borda merged commit 1bbbded into master Jan 17, 2022
@Borda Borda deleted the refactor/stoi branch January 17, 2022 13:01
@mergify mergify bot added the ready label Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@quancs quancs quancs approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@stancld stancld stancld approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@edenlightning edenlightning Awaiting requested review from edenlightning

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
API / design ready refactoring refactoring and code health
Projects
None yet
Milestone
v0.7
Development

Successfully merging this pull request may close these issues.
5 participants
@Borda @justusschock @quancs @SkafteNicki @stancld