Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev domain imports #757

Merged
merged 6 commits into from
Jan 14, 2022
Merged

rev domain imports #757

merged 6 commits into from
Jan 14, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 14, 2022

What does this PR do?

Fixes #756
Preserving conditional imports in the domain level

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda enabled auto-merge (squash) January 14, 2022 17:59
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #757 (4b93c80) into master (7deadff) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #757   +/-   ##
=====================================
  Coverage      94%    94%           
=====================================
  Files         171    171           
  Lines        6880   6888    +8     
=====================================
+ Hits         6492   6500    +8     
  Misses        388    388           

Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready label Jan 14, 2022
@mergify mergify bot removed the ready label Jan 14, 2022
@Borda Borda disabled auto-merge January 14, 2022 22:32
@Borda Borda merged commit d851103 into master Jan 14, 2022
@Borda Borda deleted the fix/imports branch January 14, 2022 22:33
@mergify mergify bot added the ready label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API / design bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing 'ROUGEScore' from 'torchmetrics.text' in 0.7.0rc0
3 participants