-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Extended Edit Distance (EED) metric #668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mathemusician, thanks for your contribution! :] I left some comments but we're on the way. You can also update CHANGELOG.md
:]
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
======================================
- Coverage 95% 95% -0%
======================================
Files 167 169 +2
Lines 6596 6718 +122
======================================
+ Hits 6272 6384 +112
- Misses 324 334 +10 |
Thanks for taking a look at my code @stancld! Will implement changes soon. |
…s to non-parallelized metric; a few type-checking bugs squashed
for more information, see https://pre-commit.ci
Co-authored-by: Daniel Stancl <[email protected]>
Thanks to everyone who reviewed my code and made this as good as it is now! :) |
Thank you for your patience with us and for making this package even better! |
Hello all, the only thing I've not done yet is update Changelog.md. I'm assuming it should be updated after review.
What does this PR do?
Fixes #635
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃