Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSIM memory #539

Merged
merged 3 commits into from
Sep 21, 2021
Merged

Fix SSIM memory #539

merged 3 commits into from
Sep 21, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 21, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #529
Old strategy crates a list of tensors that is much longer than required for the computation. New strategy thus saves some memory.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #539 (148c2e3) into master (68e5636) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #539   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         132    132           
  Lines        4676   4676           
=====================================
- Hits         4457   4451    -6     
- Misses        219    225    +6     

@Borda
Copy link
Member

Borda commented Sep 21, 2021

@SkafteNicki "ready-to-go" is an automated label, so you cannot cheat it :D

@mergify mergify bot added the ready label Sep 21, 2021
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@SkafteNicki SkafteNicki merged commit e93bae1 into master Sep 21, 2021
@SkafteNicki SkafteNicki deleted the fix_ssim_memory branch September 21, 2021 15:57
@SkafteNicki
Copy link
Member Author

@SkafteNicki "ready-to-go" is an automated label, so you cannot cheat it :D

@Borda fair enough. Then I just create a "Nicki says this is ready to go" label :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_ssim_compute creates extra tensors
3 participants