-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSIM memory #539
Fix SSIM memory #539
Conversation
Codecov Report
@@ Coverage Diff @@
## master #539 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 132 132
Lines 4676 4676
=====================================
- Hits 4457 4451 -6
- Misses 219 225 +6 |
@SkafteNicki "ready-to-go" is an automated label, so you cannot cheat it :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
@Borda fair enough. Then I just create a "Nicki says this is ready to go" label :P |
Before submitting
What does this PR do?
Fixes #529
Old strategy crates a list of tensors that is much longer than required for the computation. New strategy thus saves some memory.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃