New Audio Metric: stoi #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 134 136 +2
Lines 4873 4926 +53
=====================================
+ Hits 4632 4679 +47
- Misses 241 247 +6 |
SkafteNicki
reviewed
Sep 21, 2021
|
With PR #535 finally merge we can begin on this PR :] |
quancs
requested review from
ananyahjha93,
Borda,
edenlightning,
ethanwharris and
justusschock
as code owners
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@quancs mind check the last comments? 🐰 |
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Borda
approved these changes
Oct 14, 2021
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
for more information, see https://pre-commit.ci
The last comments are OK for me. |
for more information, see https://pre-commit.ci
SeanNaren
approved these changes
Oct 14, 2021
SkafteNicki
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #353
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃