Add None as reduction option in CosineSimilarity #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @SkafteNicki! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-29 15:13:48 UTC |
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 96.15% 96.13% -0.03%
==========================================
Files 124 124
Lines 3977 3980 +3
==========================================
+ Hits 3824 3826 +2
- Misses 153 154 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
nice, you did even add reduction value assertion. |
|
@SkafteNicki still a draft? |
SkafteNicki
requested review from
ananyahjha93,
Borda,
justusschock and
tchaton
as code owners
Borda
approved these changes
Jul 28, 2021
|
@SkafteNicki mind check the failing tests? |
awaelchli
approved these changes
Jul 29, 2021
Co-authored-by: Adrian Wälchli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #398
Adds
Noneas reduction option in cosine similarity to be consistent with codebasePR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃