Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio pesq #385

Closed
wants to merge 11 commits into from
Closed

Audio pesq #385

wants to merge 11 commits into from

Conversation

quancs
Copy link
Member

@quancs quancs commented Jul 18, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #353.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jul 18, 2021

Codecov Report

Merging #385 (0758261) into master (5c2069e) will decrease coverage by 20.11%.
The diff coverage is 60.86%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #385       +/-   ##
===========================================
- Coverage   96.45%   76.33%   -20.12%     
===========================================
  Files         113      115        +2     
  Lines        3691     3736       +45     
===========================================
- Hits         3560     2852      -708     
- Misses        131      884      +753     
Flag Coverage Δ
Linux 76.33% <60.86%> (-0.20%) ⬇️
Windows 76.33% <60.86%> (-0.20%) ⬇️
cpu 76.33% <60.86%> (-20.06%) ⬇️
gpu ?
macOS 76.33% <60.86%> (-20.06%) ⬇️
pytest 76.33% <60.86%> (-20.12%) ⬇️
python3.6 ?
python3.8 ?
python3.9 ?
torch1.3.1 ?
torch1.4.0 ?
torch1.9.0 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/audio/pesq.py 54.54% <54.54%> (ø)
torchmetrics/functional/audio/pesq.py 60.00% <60.00%> (ø)
torchmetrics/__init__.py 100.00% <100.00%> (ø)
torchmetrics/audio/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/__init__.py 100.00% <100.00%> (ø)
torchmetrics/functional/audio/__init__.py 100.00% <100.00%> (ø)
torchmetrics/utilities/distributed.py 17.24% <0.00%> (-81.04%) ⬇️
torchmetrics/image/kid.py 20.22% <0.00%> (-76.41%) ⬇️
torchmetrics/image/inception.py 31.70% <0.00%> (-63.42%) ⬇️
torchmetrics/image/fid.py 34.09% <0.00%> (-50.00%) ⬇️
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c2069e...0758261. Read the comment docs.

@quancs quancs marked this pull request as ready for review July 18, 2021 15:48
@quancs quancs closed this Jul 19, 2021
@Borda Borda added this to the v0.5 milestone Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of more audio metrics
2 participants