Fix corner case in manually specifying compute_groups in MetricCollection
#2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
justusschock,
Borda and
stancld
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2979 +/- ##
======================================
- Coverage 70% 70% -0%
======================================
Files 350 350
Lines 19532 19538 +6
======================================
Hits 13589 13589
- Misses 5943 5949 +6 |
Borda
changed the title
compute_groups in `MetricCollectioncompute_groups in MetricCollection
Borda
approved these changes
Feb 27, 2025
Borda
reviewed
Feb 27, 2025
Borda
reviewed
Feb 27, 2025
4 tasks
Borda
pushed a commit
that referenced
this pull request
Feb 28, 2025
…lection` (#2979) * implementation * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit a8de07d)
Borda
pushed a commit
that referenced
this pull request
Mar 3, 2025
…lection` (#2979) * implementation * Apply suggestions from code review --------- Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Jirka B <[email protected]> (cherry picked from commit a8de07d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2897
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2979.org.readthedocs.build/en/2979/