Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for MetricCollection.update gives identical results #2944

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rbedyakin
Copy link

@rbedyakin rbedyakin commented Feb 4, 2025

What does this PR do?

Fixes #2916

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2944.org.readthedocs.build/en/2944/

@Borda Borda changed the title fix issue 2916 fix for MetricCollection.update gives identical results Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (2ffcedf) to head (334ea90).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2944   +/-   ##
======================================
- Coverage      70%     70%   -0%     
======================================
  Files         332     332           
  Lines       18996   18998    +2     
======================================
  Hits        13253   13253           
- Misses       5743    5745    +2     

@mergify mergify bot added the ready label Feb 6, 2025
@mergify mergify bot added has conflicts and removed ready labels Feb 6, 2025
@mergify mergify bot removed the has conflicts label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricCollection.update gives identical results
2 participants