Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req: remove void requirements after bump to py3.9+ #2917

Merged
merged 8 commits into from
Feb 3, 2025
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 25, 2025

What does this PR do?

removing requirements that are not valid since we bumped min python version to 3.9

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2917.org.readthedocs.build/en/2917/

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70%. Comparing base (767c678) to head (a954328).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #2917    +/-   ##
=======================================
+ Coverage      69%     70%    +1%     
=======================================
  Files         346     346            
  Lines       19172   19172            
=======================================
+ Hits        13236   13428   +192     
+ Misses       5936    5744   -192     

requirements/_docs.txt Outdated Show resolved Hide resolved
@Borda Borda merged commit af95b0e into master Feb 3, 2025
61 of 69 checks passed
@Borda Borda deleted the req/cleaning branch February 3, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant