-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add reset_forward_cache
to Metric
#260
Conversation
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 96.83% 96.81% -0.02%
==========================================
Files 184 92 -92
Lines 6026 3013 -3013
==========================================
- Hits 5835 2917 -2918
+ Misses 191 96 -95
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@tchaton from a metrics standpoint, |
I also think this shouldn't be part of this package but part of lightning since torchmetrics is supposed to be lightning agnostic |
Before submitting
What does this PR do?
This PR adds
reset_forward_cache
option to Metric.When wrapping Metric in Metric, the
forward_cache
get overridden. This option enables to get skip this.This would be used in Logging Refactor in Lightning: Lightning-AI/pytorch-lightning#7631
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃