Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing unsqueeze AUC #242

Merged
merged 10 commits into from
May 12, 2021
Merged

fixing unsqueeze AUC #242

merged 10 commits into from
May 12, 2021

Conversation

justusschock
Copy link
Member

Before submitting

Allows to support tensors that can be squeezed to 1d tensors (e.g. trailing dims of 1) for auc and fixes a typo

@pep8speaks
Copy link

pep8speaks commented May 11, 2021

Hello @justusschock! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-11 14:32:25 UTC

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #242 (d398246) into master (683d091) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files         184      184           
  Lines        6016     6024    +8     
=======================================
+ Hits         5825     5833    +8     
  Misses        191      191           
Flag Coverage Δ
Linux 79.05% <50.00%> (-0.04%) ⬇️
Windows 79.05% <50.00%> (-0.04%) ⬇️
cpu 96.81% <100.00%> (+<0.01%) ⬆️
gpu 96.84% <ø> (+<0.01%) ⬆️
macOS 96.81% <100.00%> (+<0.01%) ⬆️
pytest 96.82% <100.00%> (+<0.01%) ⬆️
python3.6 95.75% <100.00%> (+<0.01%) ⬆️
python3.8 96.81% <100.00%> (+<0.01%) ⬆️
python3.9 96.71% <100.00%> (+<0.01%) ⬆️
torch1.3.1 95.75% <100.00%> (+<0.01%) ⬆️
torch1.4.0 95.88% <100.00%> (+<0.01%) ⬆️
torch1.8.1 96.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/functional/classification/auc.py 90.32% <100.00%> (+1.43%) ⬆️
.../1/s/torchmetrics/functional/classification/auc.py 90.32% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 683d091...d398246. Read the comment docs.

@Borda Borda changed the title Update auc.py fixing unsqueeze AUC May 11, 2021
@Borda Borda added the bug / fix Something isn't working label May 11, 2021
@Borda Borda marked this pull request as draft May 11, 2021 11:34
@Borda Borda marked this pull request as ready for review May 11, 2021 13:24
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add chlog :]

@justusschock
Copy link
Member Author

@Borda done :)

@Borda Borda enabled auto-merge (squash) May 11, 2021 14:30
@Borda Borda added ready enhancement New feature or request labels May 11, 2021
@Borda Borda merged commit b3e42b9 into master May 12, 2021
@Borda Borda deleted the justusschock-patch-1 branch May 12, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants