Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logging MultiTaskWrapper in lightning. #2213

Merged
merged 5 commits into from
Nov 18, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 14, 2023

What does this PR do?

Fixes #2193
Will allow this wrapper (which is a specialized version of MetricCollection) to be logged directly through log_dict.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2213.org.readthedocs.build/en/2213/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Nov 14, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Nov 14, 2023
@SkafteNicki SkafteNicki self-assigned this Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2213 (559183d) into master (28ac2b2) will decrease coverage by 49%.
Report is 1 commits behind head on master.
The diff coverage is 40%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2213     +/-   ##
========================================
- Coverage      87%     38%    -49%     
========================================
  Files         293     293             
  Lines       16414   16423      +9     
========================================
- Hits        14270    6201   -8069     
- Misses       2144   10222   +8078     

@Borda Borda enabled auto-merge (squash) November 14, 2023 17:24
@mergify mergify bot added the ready label Nov 14, 2023
@Borda Borda requested a review from a team November 15, 2023 10:11
@Borda Borda merged commit c53eb41 into master Nov 18, 2023
@Borda Borda deleted the log_dict_for_multitask_wrapper branch November 18, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiTaskWrapper doesn't support being logged as a metric
3 participants