Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] PSNR should use add_state #214

Merged
merged 8 commits into from
Apr 30, 2021
Merged

[bugfix] PSNR should use add_state #214

merged 8 commits into from
Apr 30, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Apr 29, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • [n/a] Did you make sure to update the docs?
  • [n/a] Did you write any new necessary tests?

What does this PR do?

Fixes Lightning-AI/pytorch-lightning#7273, Lightning-AI/pytorch-lightning#7257

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton added this to the v0.4 milestone Apr 29, 2021
@tchaton tchaton self-assigned this Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #214 (b12b4de) into master (8eb462f) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   79.66%   79.67%   +0.01%     
==========================================
  Files          90       90              
  Lines        2872     2874       +2     
==========================================
+ Hits         2288     2290       +2     
  Misses        584      584              
Flag Coverage Δ
Linux 79.67% <66.66%> (+0.01%) ⬆️
Windows 79.67% <66.66%> (+0.01%) ⬆️
cpu 79.67% <66.66%> (+0.01%) ⬆️
macOS 79.67% <66.66%> (+0.01%) ⬆️
pytest 79.67% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/regression/psnr.py 78.26% <0.00%> (ø)
torchmetrics/metric.py 55.79% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb462f...b12b4de. Read the comment docs.

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torchmetrics/metric.py Show resolved Hide resolved
@SkafteNicki SkafteNicki added ready bug / fix Something isn't working and removed ready labels Apr 29, 2021
@Borda Borda enabled auto-merge (squash) April 29, 2021 21:19
@Borda Borda disabled auto-merge April 29, 2021 21:19
@Borda Borda enabled auto-merge (squash) April 29, 2021 21:20
@Borda Borda merged commit 5510ccd into master Apr 30, 2021
@Borda Borda deleted the fix_metric branch April 30, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning + DeepSpeed + Metrics: RuntimeError: Tensors must be CUDA and dense
4 participants