-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New metric: Fowlkes-Mallows Index #2066
Merged
SkafteNicki
merged 7 commits into
Lightning-AI:master
from
matsumotosan:2003-fowlkes-mallows
Sep 11, 2023
Merged
New metric: Fowlkes-Mallows Index #2066
SkafteNicki
merged 7 commits into
Lightning-AI:master
from
matsumotosan:2003-fowlkes-mallows
Sep 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
========================================
- Coverage 87% 36% -51%
========================================
Files 285 287 +2
Lines 16021 16069 +48
========================================
- Hits 13916 5821 -8095
- Misses 2105 10248 +8143 |
SkafteNicki
approved these changes
Sep 11, 2023
src/torchmetrics/functional/clustering/fowlkes_mallows_index.py
Outdated
Show resolved
Hide resolved
Borda
approved these changes
Sep 11, 2023
matsumotosan
added a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
* initial commit * Update pyproject.toml * Update pyproject.toml again * Update CHANGELOG.md * fix import * Update src/torchmetrics/functional/clustering/fowlkes_mallows_index.py --------- Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2003
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃