-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument average
to MeanAveragePrecision
#2018
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2018 +/- ##
========================================
- Coverage 87% 38% -49%
========================================
Files 275 277 +2
Lines 15650 15733 +83
========================================
- Hits 13567 5997 -7570
- Misses 2083 9736 +7653 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!!!! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @SkafteNicki for such a quick turnaround on the feature request! Please let us know when torchmetrics
may be released with this aggregate suport on MAP for object detection, and we can add the aggregate method back on our side on the RAI toolbox repo :)
@Advitya17 regarding release: so we just relased v1.1 of torchmetrics which this feature did not end up being part of. Therefore it may take some time before v1.2 is released. We do not really have fixed dates for released, but do it more dynamically based on when enough features have been added. |
pls check the |
@SkafteNicki shall we include it in |
@Borda fine by me. Do note it is not a bug-fix but a new feature as it has never been a feature of torchmetrics. |
yes I know, but addressing an user issue 🦩 |
(cherry picked from commit 63c7bbe)
What does this PR do?
Fixes #2004
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2018.org.readthedocs.build/en/2018/