Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show must go on #198

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Show must go on #198

merged 2 commits into from
Apr 23, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Apr 23, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #198 (adc6254) into master (d3058c4) will decrease coverage by 16.70%.
The diff coverage is n/a.

❗ Current head adc6254 differs from pull request most recent head 5339f12. Consider uploading reports for the commit 5339f12 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #198       +/-   ##
===========================================
- Coverage   96.63%   79.93%   -16.71%     
===========================================
  Files         180       90       -90     
  Lines        5760     2870     -2890     
===========================================
- Hits         5566     2294     -3272     
- Misses        194      576      +382     
Flag Coverage Δ
Linux 79.93% <ø> (ø)
Windows 79.93% <ø> (ø)
cpu 79.93% <ø> (-16.71%) ⬇️
gpu ?
macOS 79.93% <ø> (-16.71%) ⬇️
pytest 79.93% <ø> (-16.71%) ⬇️
python3.6 ?
python3.8 ?
python3.9 ?
torch1.3.1 ?
torch1.4.0 ?
torch1.8.1 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/utilities/distributed.py 22.85% <0.00%> (-74.29%) ⬇️
torchmetrics/classification/auc.py 47.61% <0.00%> (-52.39%) ⬇️
torchmetrics/functional/classification/auroc.py 46.15% <0.00%> (-40.01%) ⬇️
torchmetrics/metric.py 56.17% <0.00%> (-39.05%) ⬇️
torchmetrics/functional/regression/psnr.py 60.60% <0.00%> (-36.37%) ⬇️
torchmetrics/functional/classification/accuracy.py 57.57% <0.00%> (-36.37%) ⬇️
...chmetrics/functional/classification/stat_scores.py 66.66% <0.00%> (-33.34%) ⬇️
...rics/functional/classification/confusion_matrix.py 66.66% <0.00%> (-33.34%) ⬇️
torchmetrics/utilities/checks.py 60.54% <0.00%> (-31.90%) ⬇️
torchmetrics/functional/classification/f_beta.py 73.91% <0.00%> (-26.09%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3058c4...5339f12. Read the comment docs.

@Borda Borda added documentation Improvements or additions to documentation ready labels Apr 23, 2021
@Borda Borda merged commit 2584345 into master Apr 23, 2021
@Borda Borda deleted the next branch April 23, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants