allow MetricCollection with args

[Borda]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
• Did you write any new necessary tests?

What does this PR do?

Allow passing metrics as arguments...

# Example (input as arguments):
metrics = MetricCollection(
    Accuracy(),
    Precision(num_classes=3, average='macro'),
    Recall(num_classes=3, average='macro'),
)

reaction to #175 (comment)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #176 (229624c) into master (6116c45) will increase coverage by 0.08%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   79.19%   79.28%   +0.08%     
==========================================
  Files          90       90              
  Lines        2850     2862      +12     
==========================================
+ Hits         2257     2269      +12     
  Misses        593      593              

Flag	Coverage Δ
Linux	79.28% <94.11%> (+0.08%)	⬆️
Windows	79.28% <94.11%> (+0.08%)	⬆️
cpu	79.28% <94.11%> (+0.08%)	⬆️
macOS	79.28% <94.11%> (+0.08%)	⬆️
pytest	79.28% <94.11%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
torchmetrics/average.py	83.33% <ø> (ø)
torchmetrics/collections.py	78.33% <92.30%> (+4.33%)	⬆️
...hmetrics/classification/binned_precision_recall.py	96.77% <100.00%> (+0.10%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6116c45...229624c. Read the comment docs.

[Borda]

@PyTorchLightning/core-metrics and @justusschock @SkafteNicki what do you think?

[justusschock]

I like it. just some comments for the naming and to avoid iterating over the metrics twice :)

[pep8speaks]

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-19 08:35:57 UTC