Add ignore_index to Accuracy metric

[avinashsai]

Added ignore_index to Accuracy metric. Fixes #61

[codecov]

Codecov Report

Merging #155 (e383af2) into master (953b621) will decrease coverage by 16.40%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           master     #155       +/-   ##
===========================================
- Coverage   96.18%   79.77%   -16.41%     
===========================================
  Files         180       90       -90     
  Lines        5582     2784     -2798     
===========================================
- Hits         5369     2221     -3148     
- Misses        213      563      +350     

Flag	Coverage Δ
Linux	79.77% <66.66%> (-0.02%)	⬇️
Windows	79.77% <66.66%> (-0.02%)	⬇️
cpu	79.77% <66.66%> (-16.39%)	⬇️
gpu	?
macOS	79.77% <66.66%> (-16.39%)	⬇️
pytest	79.77% <66.66%> (-16.41%)	⬇️
python3.6	?
python3.8	?
python3.9	?
torch1.3.1	?
torch1.4.0	?
torch1.8.1	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
torchmetrics/functional/classification/accuracy.py	67.74% <60.00%> (-32.26%)	⬇️
torchmetrics/classification/accuracy.py	88.46% <100.00%> (-11.54%)	⬇️
torchmetrics/utilities/distributed.py	22.85% <0.00%> (-74.29%)	⬇️
torchmetrics/classification/auc.py	47.61% <0.00%> (-52.39%)	⬇️
torchmetrics/functional/classification/auroc.py	46.15% <0.00%> (-40.01%)	⬇️
torchmetrics/metric.py	55.51% <0.00%> (-39.64%)	⬇️
torchmetrics/functional/regression/psnr.py	60.60% <0.00%> (-36.37%)	⬇️
...rics/functional/classification/confusion_matrix.py	66.66% <0.00%> (-33.34%)	⬇️
torchmetrics/utilities/checks.py	60.00% <0.00%> (-32.78%)	⬇️
...chmetrics/functional/classification/stat_scores.py	63.07% <0.00%> (-30.77%)	⬇️
... and 134 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953b621...e383af2. Read the comment docs.

[avinashsai]

@SkafteNicki Please, review this

[SkafteNicki]

Hi @avinashsai,
Code is looking great, but could you add some kind of test showing it is working as intended?

[avinashsai]

I haven't added testcases. But I have checked externally with all cases. Should I add test cases in test_accuracy.py?

[SkafteNicki]

added

Yes please do so :]

[tchaton]

Please, add test with different number of ignore_index in preds, targets.

[Borda]

add test for usage and raised new error

[avinashsai]

@SkafteNicki I dont know why tests are failing.

[Borda]

@SkafteNicki I dont know why tests are failing.

it seems that the outputs do not meet expectations
https://github.com/PyTorchLightning/metrics/pull/155/checks?check_run_id=2331922213

[Borda]

@avinashsai mind check the failing tests?