-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multilabel support in ROC #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Nice addition !
@SkafteNicki mind resolve conflict, then ready to land :] |
2498586
to
9c0879f
Compare
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
===========================================
- Coverage 97.24% 79.88% -17.37%
===========================================
Files 122 70 -52
Lines 3990 2177 -1813
===========================================
- Hits 3880 1739 -2141
- Misses 110 438 +328
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@SkafteNicki seems that the tests are not correct |
@Borda thanks, had not run all test locally but they should be good now. |
Before submitting
What does this PR do?
Fixes #103
Adds multilabel support to ROC metric
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃