-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize fit hook test with different precision plugins #8070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
added
feature
Is an improvement or enhancement
ci
Continuous Integration
labels
Jun 22, 2021
carmocca
requested review from
awaelchli,
Borda,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
June 22, 2021 00:09
Codecov Report
@@ Coverage Diff @@
## master #8070 +/- ##
======================================
- Coverage 93% 92% -0%
======================================
Files 212 212
Lines 13729 13729
======================================
- Hits 12752 12685 -67
- Misses 977 1044 +67 |
carmocca
commented
Jun 22, 2021
11 tasks
carmocca
force-pushed
the
tests/parametrize-hooks-precision-plugins
branch
2 times, most recently
from
June 22, 2021 14:44
618bfe6
to
9c33aac
Compare
carmocca
force-pushed
the
tests/parametrize-hooks-precision-plugins
branch
4 times, most recently
from
June 22, 2021 15:14
cd9fb6f
to
ae92cb2
Compare
carmocca
force-pushed
the
tests/parametrize-hooks-precision-plugins
branch
from
June 22, 2021 15:20
ae92cb2
to
39c4a85
Compare
This reverts commit 39c4a85.
11 tasks
This reverts commit e0a3e87.
…hooks-precision-plugins
SeanNaren
approved these changes
Jul 5, 2021
awaelchli
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The plugins are deepspeed, amp, and apex
Part of #7865
Related to the Lightning hooks review: #7740
Before submitting
PR review