-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update evaluation hook tests #8013
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8013 +/- ##
=======================================
- Coverage 92% 91% -0%
=======================================
Files 207 210 +3
Lines 13389 13576 +187
=======================================
+ Hits 12259 12411 +152
- Misses 1130 1165 +35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the explicit tests we had before more :)
I didn't change it to code-golf it. It has the advantage of easily checking any divergence between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Definitely great value to validate validate vs test, but the structure seems more convoluted now.
Co-authored-by: Jirka Borovec <[email protected]>
What does this PR do?
Related to the Lightning hooks review: #7740
Before submitting
PR review