Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LightningModule hook tests #7944

Merged
merged 7 commits into from
Jun 14, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jun 11, 2021

What does this PR do?

  • Create HookedLightningModule to append the called hooks dynamically. Any new hook will make the test fail. We want this so there's no forgetting to update the test.

Related to the Lightning hooks review: #7740

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added bug Something isn't working ci Continuous Integration labels Jun 11, 2021
@carmocca carmocca added this to the v1.4 milestone Jun 11, 2021
@carmocca carmocca requested a review from awaelchli as a code owner June 11, 2021 13:27
@carmocca carmocca self-assigned this Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #7944 (3b588a7) into master (436fc53) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #7944   +/-   ##
======================================
- Coverage      92%     91%   -0%     
======================================
  Files         203     203           
  Lines       13125   13127    +2     
======================================
- Hits        12012   11975   -37     
- Misses       1113    1152   +39     

@mergify mergify bot removed the has conflicts label Jun 13, 2021
@mergify mergify bot removed the has conflicts label Jun 14, 2021
@awaelchli awaelchli added the ready PRs ready to be merged label Jun 14, 2021
@carmocca carmocca merged commit 03e7bdf into master Jun 14, 2021
@carmocca carmocca deleted the tests/dynamic-hook-tests branch June 14, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants