Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exp_save_path on the LightningModule #7266

Merged
merged 4 commits into from
Apr 29, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Apr 29, 2021

What does this PR do?

This has no other references inside of lightning today. it looks like this was added in the OG commit for lightning: 2117485

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #7266 (5750544) into master (b670647) will decrease coverage by 4%.
The diff coverage is n/a.

❗ Current head 5750544 differs from pull request most recent head 94a40fb. Consider uploading reports for the commit 94a40fb to get more accurate results

@@           Coverage Diff           @@
##           master   #7266    +/-   ##
=======================================
- Coverage      91%     87%    -4%     
=======================================
  Files         199     199            
  Lines       12798   12787    -11     
=======================================
- Hits        11679   11121   -558     
- Misses       1119    1666   +547     

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not used anywere so you can just remove it without deprecation right?

@ananthsub ananthsub added the ready PRs ready to be merged label Apr 29, 2021
@mergify mergify bot removed the has conflicts label Apr 29, 2021
@kaushikb11 kaushikb11 changed the title Deprecate exp_save_path on the LightningModule Remove exp_save_path on the LightningModule Apr 29, 2021
@ananthsub ananthsub force-pushed the depreate-exp-save-path branch from 5750544 to 94a40fb Compare April 29, 2021 20:52
@ananthsub ananthsub enabled auto-merge (squash) April 29, 2021 21:19
@williamFalcon williamFalcon disabled auto-merge April 29, 2021 21:43
@williamFalcon williamFalcon merged commit 338f5a3 into Lightning-AI:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants