-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove exp_save_path on the LightningModule #7266
Remove exp_save_path on the LightningModule #7266
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7266 +/- ##
=======================================
- Coverage 91% 87% -4%
=======================================
Files 199 199
Lines 12798 12787 -11
=======================================
- Hits 11679 11121 -558
- Misses 1119 1666 +547 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not used anywere so you can just remove it without deprecation right?
5750544
to
94a40fb
Compare
What does this PR do?
This has no other references inside of lightning today. it looks like this was added in the OG commit for lightning: 2117485
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃