fixing TensorBoard #687
fixing TensorBoard #687
Conversation
drop test_tube dependence
|
fighting with while installing the package... see https://travis-ci.org/Borda/pytorch-lightning/jobs/637518732#L838 |
|
@PyTorchLightning/core-contributors ^^ |
| # save the metatags file | ||
| df = pd.DataFrame({'key': list(self.tags.keys()), | ||
| 'value': list(self.tags.values())}) | ||
| df.to_csv(meta_tags_path, index=False) |
There was a problem hiding this comment.
Shouldn't all this tag saving stuff go into the log_hyperparams function, not log_metrics?
There was a problem hiding this comment.
good question, what do you propose? @williamFalcon
There was a problem hiding this comment.
I think you can just move all this new code up into where the warning is in log_hyperparams.
There was a problem hiding this comment.
agreed with @neggert
There was a problem hiding this comment.
so you want to do a save always when a new parameter is added?
it makes more sense for me to do it while saving...
There was a problem hiding this comment.
log_metrics gets called all the time. we shouldn’t save the csv over and over when that happens.
There was a problem hiding this comment.
so saving it in save() is fine? or am I missing something...
There was a problem hiding this comment.
i haven’t looked at this in a while. i would just put it where test tube does it
There was a problem hiding this comment.
test-tube does it while saving too, that's how I "copy-paste" it...
https://github.com/williamFalcon/test-tube/blob/master/test_tube/log.py#L366
There was a problem hiding this comment.
log_hyperparams is intended to be called once at the beginning of training. I think that's what we want.
| # try if the new sub-folder exists, typical case for test-tube | ||
| if not os.path.isdir(path_expt): | ||
| path_expt = path_dir | ||
| return path_expt |
There was a problem hiding this comment.
Lots of special cases for test tube here. Fine for now to get the build passing, but let's revisit later and see if we can avoid special cases.
There was a problem hiding this comment.
agree, this was just a side-work when I was updating paths/links and found that the master fails... shall we make a ticket for it so we won't forget?
|
@Borda |
|
have you met the following issue? https://app.circleci.com/jobs/github/Borda/pytorch-lightning/839 |
|
@williamFalcon @neggert ready to go... |
|
@Borda let's make a different PR to make sure hparams don't save on every log metrics |
* updated gitignore * Update README.md * updated gitignore * updated links in ninja file * updated docs * Update README.md * Update README.md * finished callbacks * finished callbacks * finished callbacks * fixed left menu * added callbacks to menu * added direct links to docs * added direct links to docs * added direct links to docs * added direct links to docs * added direct links to docs * fixing TensorBoard (#687) * flake8 * fix typo * fix tensorboardlogger drop test_tube dependence * formatting * fix tensorboard & tests * upgrade Tensorboard * test formatting separately * try to fix JIT issue * add tests for 1.4 * added direct links to docs * updated gitignore * updated links in ninja file * updated docs * finished callbacks * finished callbacks * finished callbacks * fixed left menu * added callbacks to menu * added direct links to docs * added direct links to docs * added direct links to docs * added direct links to docs * added direct links to docs * added direct links to docs * finished rebase * making private members * making private members * making private members * working on trainer docs * working on trainer docs * working on trainer docs * working on trainer docs * working on trainer docs * working on trainer docs * set auto dp if no backend * working on trainer docs * working on trainer docs * working on trainer docs * working on trainer docs * working on trainer docs * working on trainer docs * working on trainer docs * working on trainer docs * fixed lightning import * cleared spaces * cleared spaces * cleared spaces * cleared spaces * cleared spaces * cleared spaces * cleared spaces * cleared spaces * cleared spaces * cleared spaces * finished lightning module * finished lightning module * finished lightning module * finished lightning module * added callbacks * added loggers * added loggers * added loggers * added loggers * added loggers * added loggers * added loggers * added loggers * set auto dp if no backend * added loggers * added loggers * added loggers * added loggers * added loggers * added loggers * flake 8 * flake 8 Co-authored-by: Jirka Borovec <[email protected]>
What does this PR do?
After a couple last merges the master is failing again, so this is an attempt to get it back on track...
in particular, the replacement of Test-tube by buildin TnesorBorard was not ready... #609
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.