Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Patch Release v.1.2.7 [full merge, no squash] #6850

Merged
merged 18 commits into from
Apr 7, 2021
Merged

Weekly Patch Release v.1.2.7 [full merge, no squash] #6850

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
51e9591
update readme by v1.2.x (#6728)
Borda Mar 29, 2021
553c3e5
[bugfix] Add support for omegaconf and tpu (#6741)
tchaton Mar 30, 2021
34e7282
[docs] Update Bolts link (#6743)
akihironitta Mar 30, 2021
709b695
Update logic for checking TPUs availability (#6767)
kaushikb11 Mar 31, 2021
8c01064
resolve bug (#6781)
tchaton Apr 1, 2021
5c9dbc3
Fix validation progress counter with check_val_every_n_epoch > 1 (#5952)
sailordiary Apr 2, 2021
591a087
Remove extinct parameters from lightning_module.rst (#6801)
elimohl Apr 2, 2021
2ceed8a
Update TPU docs for installation (#6794)
kaushikb11 Apr 3, 2021
17969f3
fix boolean check on iterable dataset when len not defined (#6828)
awaelchli Apr 5, 2021
cd997d6
Sanitize `None` params during pruning (#6836)
karthikprasad Apr 5, 2021
c92f84a
Fix `unfreeze_and_add_param_group` expects `modules` rather than `mod…
sadiqj Apr 5, 2021
31b2d2b
Enforce an epoch scheduler interval when using SWA (#6588)
mibaumgartner Apr 6, 2021
215a9c9
Fix DPP + SyncBN (#6838)
BloodAxe Apr 6, 2021
3643954
[Fix] TPU Training Type Plugin (#6816)
kaushikb11 Apr 6, 2021
716ade5
Fix support for symlink save_dir in TensorBoardLogger (#6730)
ethanwharris Apr 6, 2021
653232c
Fixed missing arguments in `lr_find` call (#6784)
THasthika Apr 6, 2021
c8c5d05
Update Changelog & version
kaushikb11 Apr 6, 2021
86f6d08
Fix TPU tests for checkpoint
kaushikb11 Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pytorch_lightning/plugins/training_type/tpu_spawn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,14 @@ def test_step(self, *args, **kwargs):
def predict(self, *args, **kwargs):
return self.lightning_module.predict(*args, **kwargs)

def save_checkpoint(self, checkpoint: Dict[str, Any], filepath: str) -> None:
def save_checkpoint(self, filepath: str, weights_only: bool = False) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaton @kaushikb11 where/when we changed this API?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in this PR: 646cf2f
You can use git blame to find the associated PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I know I just say that the API is different / not back compatible

"""Save model/training states as a checkpoint file through state-dump and file-write.
Args:
checkpoint: dict containing model and trainer state
filepath: write-target file's path
weights_only: saving model weights only
"""
# dump states as a checkpoint dictionary object
checkpoint = self.lightning_module.trainer.checkpoint_connector.dump_checkpoint(weights_only)
# Todo: TypeError: 'mappingproxy' object does not support item assignment
if _OMEGACONF_AVAILABLE:
checkpoint = apply_to_collection(checkpoint, (DictConfig, ListConfig), OmegaConf.to_container)
Expand Down
6 changes: 3 additions & 3 deletions tests/models/test_tpu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def test_model_16bit_tpu_cores_1(tmpdir):
progress_bar_refresh_rate=0,
max_epochs=2,
tpu_cores=1,
limit_train_batches=8,
limit_train_batches=0.7,
limit_val_batches=2,
)

Expand Down Expand Up @@ -210,8 +210,8 @@ def test_tpu_grad_norm(tmpdir):
progress_bar_refresh_rate=0,
max_epochs=4,
tpu_cores=1,
limit_train_batches=0.4,
limit_val_batches=0.4,
limit_train_batches=10,
limit_val_batches=10,
gradient_clip_val=0.5,
)

Expand Down
2 changes: 2 additions & 0 deletions tests/test_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import pytest

from pytorch_lightning.profiler import AdvancedProfiler, SimpleProfiler
from tests.helpers.runif import RunIf

PROFILER_OVERHEAD_MAX_TOLERANCE = 0.0005

Expand Down Expand Up @@ -165,6 +166,7 @@ def test_advanced_profiler_overhead(advanced_profiler, n_iter=5):
assert average_duration < PROFILER_OVERHEAD_MAX_TOLERANCE


@RunIf(max_torch="1.8.1")
def test_advanced_profiler_describe(tmpdir, advanced_profiler):
"""
ensure the profiler won't fail when reporting the summary
Expand Down
2 changes: 2 additions & 0 deletions tests/trainer/test_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
from pytorch_lightning.utilities.exceptions import MisconfigurationException
from tests.base import EvalModelTemplate
from tests.helpers import BoringModel, RandomDataset
from tests.helpers.runif import RunIf


@pytest.fixture
Expand Down Expand Up @@ -1499,6 +1500,7 @@ def test_trainer_predict_ddp_cpu(tmpdir):
predict(tmpdir, "ddp_cpu", 0, 2)


@RunIf(max_torch="1.8.1")
def test_pytorch_profiler_describe(pytorch_profiler):
"""Ensure the profiler won't fail when reporting the summary."""
with pytorch_profiler.profile("test_step"):
Expand Down