-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly Patch Release v.1.2.5 [full merge, no squash] #6646
Conversation
13b2113
to
b762fb4
Compare
40d952c
to
caebaea
Compare
the same error as in #6536 (comment) |
13e7c2c
to
c3be721
Compare
Co-authored-by: chaton <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit bc577ca)
* update doc * update example (cherry picked from commit 8853a36)
(cherry picked from commit 983a888)
(cherry picked from commit 87c03b1)
* try Azure * -e * path (cherry picked from commit cb59039)
* refactoring setup * . * docs * flake8 (cherry picked from commit 1fae10a)
* fix comparing versions * chlog * . * ... * datasets (cherry picked from commit 8cd75a4)
* Add Tests for val and test-steps * Add native AMP * pep8 tests * pep8 plugin * changelog (cherry picked from commit 634d831)
273cf64
to
d492cd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
missing #6536 as the test does not pass, probably needs some other commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
from torchmetrics import Metric as TMetric | ||
|
||
from pytorch_lightning import Trainer | ||
from pytorch_lightning.metrics import Metric, MetricCollection | ||
from pytorch_lightning.metrics import Metric as PLMetric | ||
from pytorch_lightning.metrics import MetricCollection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchaton van you pls double check that this is sufficient compatibility test for PL and TM metrics
* base class * extensions * chlog * _stable_1d_sort * _check_same_shape * _input_format_classification_one_hot * utils * to_onehot * select_topk * to_categorical * get_num_classes * reduce * class_reduce * tests (cherry picked from commit 6453091)
What does this PR do?
Refers to #6083
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃