Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comparing versions #6434

Merged
merged 20 commits into from
Mar 23, 2021
Prev Previous commit
Next Next commit
..+-
  • Loading branch information
Borda committed Mar 22, 2021
commit bf580c03a3cdb2d7c4226a6ed7463b2c9e4c2b2d
3 changes: 1 addition & 2 deletions pytorch_lightning/utilities/imports.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ def _compare_version(package: str, op, version) -> bool:
try:
pkg_version = LooseVersion(pkg.__version__)
except AttributeError:
# in case version is not defined always return True as likely it is mocked call
return True
return False
if str(pkg_version).endswith("__version__"):
# this is mock by sphinx, so it shall return True ro generate all summaries
return True
Expand Down