Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaning SWA #6259

Merged
merged 6 commits into from
Mar 1, 2021
+9 −8
Merged

cleaning SWA #6259

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
516ba84
rename
Borda Mar 1, 2021
7439e76
if
Borda Mar 1, 2021
c39ef97
test
Borda Mar 1, 2021
8b42311
chlog
Borda Mar 1, 2021
ced1052
drop swa
Borda Mar 1, 2021
421cfa8
Apply suggestions from code review
Borda Mar 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
drop swa
  • Loading branch information
@Borda
Borda committed Mar 1, 2021
commit ced1052797c799b6a0388ca59521b89bf268004a
8 changes: 0 additions & 8 deletions pytorch_lightning/callbacks/swa.py
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions tests/deprecated_api/test_remove_1-5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,10 @@

from pytorch_lightning import Callback, Trainer
from pytorch_lightning.loggers import WandbLogger
from tests.deprecated_api import _soft_unimport_module
from tests.helpers import BoringModel
from tests.helpers.utils import no_warning_call


def test_v1_4_0_deprecated_imports():
_soft_unimport_module('pytorch_lightning.callbacks.swa')
with pytest.deprecated_call(match='will be removed in v1.4'):
from pytorch_lightning.callbacks.swa import StochasticWeightAveraging # noqa: F811 F401


@mock.patch('pytorch_lightning.loggers.wandb.wandb')
def test_v1_5_0_wandb_unused_sync_step(tmpdir):
with pytest.deprecated_call(match=r"v1.2.1 and will be removed in v1.5"):
Expand Down